Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pingsource from HA scaling #740

Merged
merged 1 commit into from Aug 31, 2021
Merged

Remove pingsource from HA scaling #740

merged 1 commit into from Aug 31, 2021

Conversation

matzew
Copy link
Member

@matzew matzew commented Aug 31, 2021

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #

Proposed Changes

  • the pingsource is scaled, based on demand, via Knative Eventing itself - Instead of hard-wired via HA config. Therefore removing form the HA apply section

Release Note

PingSource no langer is having a replica as default. It is scaled on demand

@matzew
Remove pingsource from HA scaling
60b610c 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 31, 2021
@matzew
Copy link
Member Author

matzew commented Aug 31, 2021

/assign @lionelvillard

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2021
houshengbo
houshengbo reviewed Aug 31, 2021
View reviewed changes
Copy link
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lionelvillard
Copy link
Member

AFAIK, PingSource is not scaled on-demand. Is this new?

@knative-prow-robot knative-prow-robot merged commit ff7ab93 into knative:main Aug 31, 2021
@matzew
Copy link
Member Author

matzew commented Aug 31, 2021

@lionelvillard the adapter is created on demand, when we actually create a PingSource, it scaled up:
https://github.com/knative/eventing/blob/main/config/core/deployments/pingsource-mt-adapter.yaml#L24

that's what I meant

matzew added a commit to matzew/knative-operator that referenced this pull request Sep 13, 2021
@matzew
Remove pingsource from HA scaling (knative#740)
b03b51e 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew mentioned this pull request Sep 13, 2021
Merged
knative-prow-robot pushed a commit that referenced this pull request Sep 13, 2021
@matzew
Remove pingsource from HA scaling (#740) (#766)
aca8998 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houshengbo houshengbo houshengbo left review comments

Assignees

@houshengbo houshengbo

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matzew @knative-prow-robot @lionelvillard @houshengbo