remove goroutine in sharedmain to start informer

knative · Sep 29, 2020 · 89b56be · 89b56be
1 parent 99f7df5
commit 89b56be
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/injection/sharedmain/main.go b/injection/sharedmain/main.go
@@ -270,12 +270,9 @@ func MainWithConfig(ctx context.Context, component string, cfg *rest.Config, cto
 
 	// Start the injection clients and informers.
 	logging.FromContext(ctx).Info("Starting informers...")
-	go func(ctx context.Context) {
-		if err := controller.StartInformers(ctx.Done(), informers...); err != nil {
-			logging.FromContext(ctx).Fatalw("Failed to start informers", zap.Error(err))
-		}
-		<-ctx.Done()
-	}(ctx)
+	if err := controller.StartInformers(ctx.Done(), informers...); err != nil {
+		logging.FromContext(ctx).Fatalw("Failed to start informers", zap.Error(err))
+	}
 	// Wait for webhook informers to sync.
 	if wh != nil {
 		wh.InformersHaveSynced()