Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics does not have a default for metrics.backend-destination #212

Closed
jonjohnsonjr opened this issue Jan 8, 2019 · 1 comment
Closed

metrics does not have a default for metrics.backend-destination #212

jonjohnsonjr opened this issue Jan 8, 2019 · 1 comment
Assignees
@jonjohnsonjr
Labels
area/monitoring kind/bug Categorizes issue or PR as related to a bug.

Comments

@jonjohnsonjr
Copy link
Contributor

jonjohnsonjr commented Jan 8, 2019 •
edited
Loading

Expected Behavior

New, required fields must have a default value to avoid breaking upgrades.

Actual Behavior

metrics.backend-destination is required but not defaulted.
@knative-prow-robot knative-prow-robot added area/monitoring kind/bug Categorizes issue or PR as related to a bug. labels Jan 8, 2019
@jonjohnsonjr
Copy link
Contributor Author

/assign

jonjohnsonjr added a commit to jonjohnsonjr/pkg that referenced this issue Jan 8, 2019
@jonjohnsonjr
Default metrics.backend-destination to Prometheus
d5b57cb 
Fixes knative#212
@jonjohnsonjr jonjohnsonjr mentioned this issue Jan 8, 2019
Merged
knative-prow-robot pushed a commit that referenced this issue Jan 8, 2019
@jonjohnsonjr @knative-prow-robot
Default metrics.backend-destination to Prometheus (#213)
a8c40a9 
Fixes #212
@jonjohnsonjr jonjohnsonjr mentioned this issue Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonjohnsonjr jonjohnsonjr

Labels
area/monitoring kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonjohnsonjr @knative-prow-robot