Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/controller #8

Closed
mattmoor opened this issue Jul 25, 2018 · 1 comment
Closed

Move pkg/controller #8

mattmoor opened this issue Jul 25, 2018 · 1 comment
Assignees
@mattmoor
Labels
area/API

Comments

@mattmoor
Copy link
Member

Blocked on knative/serving#1505 (IMO)
@mattmoor
Copy link
Member Author

/area API

mattmoor added a commit to mattmoor/pkg that referenced this issue Aug 1, 2018
@mattmoor
Move our base controller infrastructure into knative/pkg.
fd9d689 
The `controller.go` is from: knative/serving#1770, however, this adds 100% coverage of `controller.go`, which we have been missing in `knative/serving`.

Fixes: knative#8
@mattmoor mattmoor mentioned this issue Aug 1, 2018
Merged
@mattmoor mattmoor self-assigned this Aug 1, 2018
mattmoor added a commit to mattmoor/pkg that referenced this issue Aug 1, 2018
@mattmoor
Move our base controller infrastructure into knative/pkg.
f98df37 
The `controller.go` is from: knative/serving#1770, however, this adds 100% coverage of `controller.go`, which we have been missing in `knative/serving`.

This also adds a `context.Context` to the `Reconcile` signature, to enable better sharing of logger setup across controllers.

Fixes: knative#8
mattmoor added a commit to mattmoor/pkg that referenced this issue Aug 1, 2018
@mattmoor
Move our base controller infrastructure into knative/pkg.
066d074 
The `controller.go` is from: knative/serving#1770, however, this adds 100% coverage of `controller.go`, which we have been missing in `knative/serving`.

This also adds a `context.Context` to the `Reconcile` signature, to enable better sharing of logger setup across controllers.

Fixes: knative#8
google-prow-robot pushed a commit that referenced this issue Aug 1, 2018
@mattmoor @google-prow-robot
Move our base controller infrastructure into knative/pkg. (#33)
bf6f9e3 
The `controller.go` is from: knative/serving#1770, however, this adds 100% coverage of `controller.go`, which we have been missing in `knative/serving`.

This also adds a `context.Context` to the `Reconcile` signature, to enable better sharing of logger setup across controllers.

Fixes: #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattmoor mattmoor

Labels
area/API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmoor @google-prow-robot