Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update boskos dependency to sigs.k8s.io/boskos #1378

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Update boskos dependency to sigs.k8s.io/boskos #1378

merged 2 commits into from
Jun 9, 2020

Conversation

ixdy
Copy link
Contributor

@ixdy ixdy commented Jun 3, 2020

Boskos has moved into kubernetes-sigs/boskos, so I'm preemptively updating the dep here so that future updates are painless. There shouldn't be any notable boskos functionality changes.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 3, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 3, 2020
@ixdy ixdy mentioned this pull request Jun 3, 2020
Closed
14 tasks
@ixdy
Copy link
Contributor Author

ixdy commented Jun 3, 2020

Running hack/update-deps.sh seems to have removed all of the ## explicit comments, and I'm not sure why.

@chaodaiG
Copy link
Contributor

chaodaiG commented Jun 3, 2020

@chizhg

Running hack/update-deps.sh seems to have removed all of the ## explicit comments, and I'm not sure why.

@chizhg , any idea?

@ixdy ixdy force-pushed the update-boskos-dependency branch from cad86e2 to 2172d56 Compare June 3, 2020 22:52
@ixdy
Copy link
Contributor Author

ixdy commented Jun 3, 2020

It looks like hack/update-k8s-deps.sh v0.17.6 has the desired result, so that should unblock me, but I think there might be something broken in hack/update-deps.sh.

@chizhg
Copy link
Member

chizhg commented Jun 3, 2020

@chizhg

Running hack/update-deps.sh seems to have removed all of the ## explicit comments, and I'm not sure why.

@chizhg , any idea?

Not sure about it. The vendor/modules.txt file is auto-generated by Go mod, and normally we don't touch it.

@chizhg
Copy link
Member

chizhg commented Jun 3, 2020

It looks like hack/update-k8s-deps.sh v0.17.6 has the desired result, so that should unblock me, but I think there might be something broken in hack/update-deps.sh.

That's weird, it looks the k8s dependencies are already in v0.17.6

@ixdy ixdy force-pushed the update-boskos-dependency branch from 2172d56 to 41a58b2 Compare June 3, 2020 22:59
@ixdy
Copy link
Contributor Author

ixdy commented Jun 3, 2020

hm, I reset everything and ran hack/update-deps.sh again, and this time it did the right thing. So I'm not really sure what's going on.

@ixdy
Copy link
Contributor Author

ixdy commented Jun 5, 2020

all tests are passing; I believe this is ready for review.

@chizhg
Copy link
Member

chizhg commented Jun 5, 2020

/lgtm
/assign @mattmoor

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 5, 2020
@ixdy ixdy force-pushed the update-boskos-dependency branch from 41a58b2 to a02cbab Compare June 9, 2020 16:27
@knative-prow-robot knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 9, 2020
@ixdy
Copy link
Contributor Author

ixdy commented Jun 9, 2020

rebased

@chizhg
Copy link
Member

chizhg commented Jun 9, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
mattmoor
mattmoor reviewed Jun 9, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@knative-prow-robot knative-prow-robot merged commit 8b0054f into knative:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@mattmoor mattmoor

@chizhg chizhg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ixdy @chaodaiG @chizhg @knative-prow-robot @mattmoor @googlebot