Delay start of informers in sharedmain #1767
Conversation
The EnableInjectionOrDie starts informers immedidately in a go routine, which changes the order of informer start and controller setup. As a result setting resync period to informer handler will be ignored as the informer is already started. Though this will likely affect more components, changing the EnableInjectionOrDie function will break the API, so this is a temporary solution to fix all the controllers depending on sharedmain.
knative-prow-robot
added
the
size/S
|
/assign @grantr |
|
/assign @n3wscott |
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
==========================================
+ Coverage 68.48% 68.53% +0.04%
==========================================
Files 215 215
Lines 9202 9216 +14
==========================================
+ Hits 6302 6316 +14
Misses 2584 2584
Partials 316 316
Continue to review full report at Codecov.
|
|
/lgtm We can follow up next week with a fix to enable injection. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott, zhongduo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Hi @n3wscott I am not sure about the process, but my original plan is to update my go.mod and regenerate the vendor directory. Are you saying that all the knative shared libraries, like this |
The EnableInjectionOrDie starts informers immedidately in a go routine, which changes the order of informer start and controller setup. As a result setting resync period to informer handler will be ignored as the informer is already started. Though this will likely affect more components, changing the EnableInjectionOrDie function will break the API, so this is a temporary solution to fix all the controllers depending on sharedmain.
The EnableInjectionOrDie starts informers immedidately in a go routine, which changes the order of informer start and controller setup. As a result setting resync period to informer handler will be ignored as the informer is already started. Though this will likely affect more components, changing the EnableInjectionOrDie function will break the API, so this is a temporary solution to fix all the controllers depending on sharedmain. Co-authored-by: Zhongduo Lin (Jimmy) <zhongduo@google.com>
The EnableInjectionOrDie starts informers immedidately in a go
routine, which changes the order of informer start and controller
setup. As a result setting resync period to informer handler will
be ignored as the informer is already started. Though this will
likely affect more components, changing the EnableInjectionOrDie
function will break the API, so this is a temporary solution to
fix all the controllers depending on sharedmain.
This is a temporary solution to #1757 . We might change it to
use whatever solution #1757 will result in, but for now this can be
an easy fix for controllers depending on sharedmain.