Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include OpenCensus in the list of metric backends #2189

Merged
merged 1 commit into from
Jul 14, 2021
Merged

include OpenCensus in the list of metric backends #2189

merged 1 commit into from
Jul 14, 2021

Conversation

dprotaso
Copy link
Member

No description provided.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 14, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2021
@dprotaso dprotaso changed the title include OpenCensus in the list of metric backend include OpenCensus in the list of metric backends Jul 14, 2021
evankanderson
evankanderson reviewed Jul 14, 2021
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member Author

/retest

I re-opened #1672 to track the flake

@knative-prow-robot knative-prow-robot merged commit 7764284 into knative:main Jul 14, 2021
@dprotaso dprotaso deleted the no-stackdriver-nits branch July 14, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dprotaso @knative-prow-robot @evankanderson