Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade generated clients to support 1.26/1.27 #2729

Closed
wants to merge 5 commits into from
Closed

Upgrade generated clients to support 1.26/1.27 #2729

wants to merge 5 commits into from

Conversation

ivanvanderbyl
Copy link

I'm new here 👋🏻 , this is an attempt to resolve 1.26/1.27 client support so that we can use this pkg outside of knative in newer projects, namely depending on sigstore/policy-controller, which depends on this.

Changes

  • Update apis and client packages
  • Generated new clients and informers
  • Deleted deprecated apis

/kind api-change
/kind enhancement

Fixes #2725

Release Note


Docs


Signed-off-by: Ivan Vanderbyl <ivanvanderbyl@gmail.com>
Signed-off-by: Ivan Vanderbyl <ivanvanderbyl@gmail.com>
Signed-off-by: Ivan Vanderbyl <ivanvanderbyl@gmail.com>
Signed-off-by: Ivan Vanderbyl <ivanvanderbyl@gmail.com>
@knative-prow knative-prow bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/enhancement labels Apr 21, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2023

CLA Not Signed

@knative-prow
Copy link

knative-prow bot commented Apr 21, 2023

Welcome @ivanvanderbyl! It looks like this is your first PR to knative/pkg 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 21, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 21, 2023

Hi @ivanvanderbyl. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Apr 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvanderbyl
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 21, 2023
@knative-prow knative-prow bot requested review from aslom and KauzClay April 21, 2023 02:21
@vaikas
Copy link
Contributor

vaikas commented Apr 21, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 21, 2023

@ivanvanderbyl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_pkg_main f50b647 link true /test unit-tests
build-tests_pkg_main f50b647 link true /test build-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Comment on lines +45 to +49
k8s.io/api v0.27.1
k8s.io/apiextensions-apiserver v0.27.1
k8s.io/apimachinery v0.27.1
k8s.io/client-go v0.27.1
k8s.io/code-generator v0.27.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're targetting v1.25 as the next k8s version that means we'll have to set these to v0.26.x

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

Superseded by #2745

@dprotaso dprotaso closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/enhancement needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.26/1.27 support
4 participants