-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade generated clients to support 1.26/1.27 #2729
Conversation
Signed-off-by: Ivan Vanderbyl <ivanvanderbyl@gmail.com>
Signed-off-by: Ivan Vanderbyl <ivanvanderbyl@gmail.com>
Signed-off-by: Ivan Vanderbyl <ivanvanderbyl@gmail.com>
Signed-off-by: Ivan Vanderbyl <ivanvanderbyl@gmail.com>
|
Welcome @ivanvanderbyl! It looks like this is your first PR to knative/pkg 🎉 |
Hi @ivanvanderbyl. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivanvanderbyl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@ivanvanderbyl: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s.io/api v0.27.1 | ||
k8s.io/apiextensions-apiserver v0.27.1 | ||
k8s.io/apimachinery v0.27.1 | ||
k8s.io/client-go v0.27.1 | ||
k8s.io/code-generator v0.27.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're targetting v1.25 as the next k8s version that means we'll have to set these to v0.26.x
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Superseded by #2745 |
I'm new here 👋🏻 , this is an attempt to resolve 1.26/1.27 client support so that we can use this pkg outside of knative in newer projects, namely depending on
sigstore/policy-controller
, which depends on this.Changes
/kind api-change
/kind enhancement
Fixes #2725
Release Note
Docs