Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop dynamic client wrappers in namespaced informers #2744

Merged
merged 1 commit into from
May 19, 2023

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented May 18, 2023

Follow up of #2742

I didn't realize these were manual created - so deleting the code manually.

Part of #2739

@knative-prow knative-prow bot requested review from aslom and izabelacg May 18, 2023 15:33
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 18, 2023
@dprotaso
Copy link
Member Author

/assign @pierDipi

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 83.78% and no project coverage change.

Comparison is base (300df43) 81.53% compared to head (b2576ff) 81.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2744   +/-   ##
=======================================
  Coverage   81.53%   81.54%           
=======================================
  Files         163      163           
  Lines       10018    10055   +37     
=======================================
+ Hits         8168     8199   +31     
- Misses       1606     1610    +4     
- Partials      244      246    +2     
Impacted Files Coverage Δ
apis/duck/v1/source_types.go 48.64% <ø> (ø)
apis/duck/v1beta1/destination.go 94.17% <83.33%> (-2.30%) ⬇️
apis/duck/v1/destination.go 94.23% <84.21%> (-5.77%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso dprotaso changed the title drop dynamic client wrappers drop dynamic client wrappers in namespaced informers May 18, 2023
Copy link

@xtreme-vikram-yadav xtreme-vikram-yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@knative-prow
Copy link

knative-prow bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, xtreme-vikram-yadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 52ff2ac into knative:main May 19, 2023
42 checks passed
@dprotaso dprotaso deleted the drop-namespaced-dynamic branch May 19, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants