Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the unused injection.Dynamic interface #2750

Merged
merged 1 commit into from
May 31, 2023
Merged

Drop the unused injection.Dynamic interface #2750

merged 1 commit into from
May 31, 2023

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented May 24, 2023 •
edited
Loading

Fixes: #2739

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2023
@dprotaso
Copy link
Member Author

/hold

Eventing hasn't updated their k8s deps - will wait for that

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@dprotaso dprotaso changed the title drop the dynamic type Drop the unused injection.Dynamic interface May 24, 2023
@dprotaso
Copy link
Member Author

@pierDipi what's left are some eventing repos - but it looks like the updates are trickling in slowly

/hold cancel
/assign @pierDipi

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@dprotaso
Copy link
Member Author

/retest

pierDipi
pierDipi approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@knative-prow
Copy link

knative-prow bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5671699 into knative:main May 31, 2023
31 of 36 checks passed
@n3wscott n3wscott mentioned this pull request Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@KauzClay KauzClay Awaiting requested review from KauzClay

@xtreme-vikram-yadav xtreme-vikram-yadav Awaiting requested review from xtreme-vikram-yadav

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop dynamic wrapped client generation
2 participants
@dprotaso @pierDipi