Support to set qps and burst via env variable #2755
Conversation
Currently some configuration such as `kube-api-burst` and `kube-api-qps` must be set via command line option. Knative deployments usually do not have the command line option, the command line option is unusual and so knative/operator also does not support the API. Hence This patch allows to set client config via env variable.
knative-prow
bot
added
approved
|
LGTM thanks @nak3! |
environment/client_config.go
Outdated
| fs.Float64Var(&c.QPS, "kube-api-qps", float64(envVarOrDefault("KUBE_API_QPS", 0)), "Maximum QPS to the server from the client.") | ||
| } | ||
|
|
||
| func envVarOrDefault(key string, val int) int { |
There was a problem hiding this comment.
I guess we dont have such a func elsewhere in the code base?
There was a problem hiding this comment.
Right, I think there is no util function like this.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
==========================================
- Coverage 82.06% 81.75% -0.32%
==========================================
Files 166 167 +1
Lines 10150 10201 +51
==========================================
+ Hits 8330 8340 +10
- Misses 1576 1614 +38
- Partials 244 247 +3
☔ View full report in Codecov by Sentry. |
|
/hold I think I found one bug... |
knative-prow
bot
added
the
do-not-merge/hold
|
/hold cancel Fixed. |
knative-prow
bot
removed
the
do-not-merge/hold
|
/hold We actually want to drop these settings from our controllers since K8s supports API priority and fairness now - https://kubernetes.io/docs/concepts/cluster-administration/flow-control/ So we should disable all client side rate limiting Some context: |
knative-prow
bot
added
the
do-not-merge/hold
|
|
|
TestMetricsExport flake /retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
Currently some configuration such as
kube-api-burstandkube-api-qpsmust be set via command line option.Knative deployments usually do not have the command line option, the command line option is unusual and so knative/operator also does not support the API.
Hence This patch allows to set client config via env variable.
Release Note