fix: downstream tests assume release branch was cut

[asr2003]

Changes

🐛 Fix bug of release branch cut:

Added following additional steps to downstream.yaml for the scenario if the checkout fails - it should fallback and checkout the main branch downstream

• Set Branch to Main if Checkout Fails: Sets the BRANCH environment variable to main if the downstream checkout fails.
• Set Branch to PR Base Ref if Checkout Succeeds: Sets the BRANCH environment variable to the PR base branch if the checkout succeeds.
• Checkout Downstream with Fallback Branch: Uses the fall back branch main if the checkout failed or the PR base branch if it succeeded.

/kind enhancement
cc: @dprotaso

• Fixes Downstream tests assume release branch was cut #2508

[knative-prow]

@asr2003: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

• Fixes Downstream tests assume release branch was cut #2508

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

Hi @asr2003. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[asr2003]

@Cali0707 @Leo6Leo @skonto PTAL and can approve the workflows?

[dprotaso]

We can skip this step if the earlier checkout succeeded

[dprotaso]

Might be simpler to not use the env var and collapse the steps into something like this

    - name: Checkout downstream with fallback branch
      if: steps.checkout-downstream.outcome == 'failure'
      uses: actions/checkout@v4
      with:
        ref: main
        repository: ${{ matrix.repo }}
        path: downstream

[asr2003]

Simplified steps as changes suggested

[asr2003]

Sure, I will make incorporate the requested changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (7d52a43) to head (0dd60c1).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3047   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files         189      189           
  Lines        8872     8872           
=======================================
  Hits         6985     6985           
  Misses       1621     1621           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

/ok-to-test
/lgtm
/approve

thanks

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asr2003, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment