Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a GetCondition method to Status #336

Merged
merged 1 commit into from Mar 23, 2019
Merged

Add a GetCondition method to Status #336

merged 1 commit into from Mar 23, 2019

Conversation

mattmoor
Copy link
Member

I wanted this when rewriting the Pipeline e2e test in Serving to use the dynamic client and checking status via this duck type.

See here: https://github.com/knative/serving/blob/b0ad29dbc869716cf5d80b7557d14472e33fc03f/test/e2e/build_pipeline_test.go#L84

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 23, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 23, 2019
@skyn1ce
Copy link

skyn1ce commented Mar 23, 2019

:)

@mattmoor
Add a GetCondition method to Status
ea62aac 
I wanted this when rewriting the Pipeline e2e test in Serving to use the dynamic client and checking status via this duck type.

See here: https://github.com/knative/serving/blob/b0ad29dbc869716cf5d80b7557d14472e33fc03f/test/e2e/build_pipeline_test.go#L84
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
apis/duck/v1alpha1/conditions_types.go 92.3% 94.1% 1.8

vagababov
vagababov reviewed Mar 23, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2019
@knative-prow-robot knative-prow-robot merged commit a5a847f into knative:master Mar 23, 2019
@mattmoor mattmoor deleted the add-get-condition branch March 23, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vagababov vagababov

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mattmoor @knative-prow-robot @skyn1ce @knative-metrics-robot @vagababov @googlebot @n3wscott