-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DomainMapper complains path on Adressable Knative Broker #12686
Comments
What eventually made it work is to point to the apiVersion: serving.knative.dev/v1alpha1
kind: DomainMapping
metadata:
name: brokers.apps.ci-ln-ksz9nx2-72292.origin-ci-int-gce.dev.rhcloud.com
namespace: knative-eventing
spec:
ref:
name: broker-ingress
kind: Service
apiVersion: v1 With this
|
When I do it with a ---
apiVersion: serving.knative.dev/v1alpha1
kind: DomainMapping
metadata:
name: kafka-channel-one.my-cloudy-server.com
namespace: default
spec:
ref:
name: kafka-channel-one
kind: KafkaChannel
apiVersion: messaging.knative.dev/v1beta1 And it is ready, like: k get kafkachannel
NAME READY REASON URL AGE
kafka-channel-one True http://kafka-channel-one-kn-channel.default.svc.cluster.local 12m I am getting this:
|
We use domain mapping in konk.dev and kn quickstart |
You're again referencing the Kubernetes Service. KIngress doesn't currently support the ability to rewrite the request path (AFAIK), so the "supports Addressable" appears to be a bit broken. This should probably be fixed for GA one way or the other (either by removing the "general Addressable" support, or by supporting path mappings). |
yes, and simple things like that do work - just not broker (for the error stated in the |
yes, as a reasonable work-around I use the actual k8s Service. and do the
yep, I agree - For the broker especially since they all (all implementations) do use the
yeah. I'd second that statement too 😄 |
I'd think that allowing |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
This is still blocking domain-mapping GA. |
This issue is stale because it has been open for 90 days with no |
This issue or pull request is stale because it has been open for 90 days with no activity. This bot triages issues and PRs according to the following rules:
You can:
/lifecycle stale |
This issue is stale because it has been open for 90 days with no |
/lifecycle frozen |
Following this guide:
https://knative.dev/docs/serving/services/custom-domains/
I set these values in the "network" ConfigMap:
So I created a
DomainMapping
for a Knative Broker:But I am getting this:
The guide does mention:
IMO this error "contains a path" does break that
The text was updated successfully, but these errors were encountered: