Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow KnativeService update to stay to same scale, eg: Initial-scale=previous #13270

Closed
pastjean opened this issue Sep 1, 2022 · 3 comments
Closed
Labels
area/autoscale kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@pastjean
Copy link

pastjean commented Sep 1, 2022

/area autoscale

Describe the feature

It would be nice to be able to update service without changing their current scale

Situation:

So we have a bunch of knative services ( > 1800 ). With all of them having scale to zero enabled. They all do have different different docker image but they do share code. It's common to update that shared code sometimes and update all those knative service.

  • allow-scale-to-zero: "true"
  • Service 1 initial-scale = 1, current-scale = 3
  • Service 2 initial-scale = 1, current-scale = 0

When updating the Services they all go back to their initial-scale instead of staying at their current scale. Meaning:

  • Service 1 = current-scale = 1
  • Service 2 = current-scale = 1

Even though autoscaler knows it needs more of Service 1  and none of Service 2.

My feature request: have a way to tell the autoscaler to put the initialScale to something like previous or current

See slack thread about the history on this: https://knative.slack.com/archives/C0186KU7STW/p1662038186291709

@pastjean pastjean added the kind/feature Well-understood/specified features, ready for coding. label Sep 1, 2022
@pastjean pastjean changed the title Initial-scale=previous Allow service update to stay to same scale, eg: Initial-scale=previous Sep 1, 2022
@pastjean pastjean changed the title Allow service update to stay to same scale, eg: Initial-scale=previous Allow KnativeService update to stay to same scale, eg: Initial-scale=previous Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2022
@knative-prow-robot
Copy link
Contributor

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 1, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2023
@github-actions github-actions bot closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/autoscale kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants