-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-Active Revisions with ScaleToZeroPodRetention and min-non-active-revisions > 1 is not scaled down #13812
Comments
I lowered this from an hour ( /triage needs-user-input |
Hey @dprotaso, Thanks for taking time to check this out. Indeed, it eventually scales down, but I think the non-active revisions can be scaled down immediately. Am i missing something? |
I guess to clarify your ask is
Or another way to phrase it
This issue might be covered by this PR - #13731 but would need to confirm |
/triage accepted I'm assuming your ask what I've described - if so I agree that revisions that aren't routable should ignore the scale down retention periods. |
You are right and let me check the PR |
Hey @dprotaso |
/remove-triage needs-user-input |
@dprotaso, can I go ahead with the fix ? |
@AswinT22 are you still working on this? |
/unassign @AswinT22 |
@dprotaso hi can I work on this? |
What version of Knative?
Expected Behavior
Non active must be scaled down with
autoscaling.knative.dev/scale-to-zero-pod-retention-period
setActual Behavior
Non active revisions are not scaled down
Steps to Reproduce the Problem
Deploy a Knative service with
scale-to-zero-pod-retention-period
(make sure this value is higher so you will be able to see the issue)Edit the config-map
config-gc
and set below valuesThe text was updated successfully, but these errors were encountered: