Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use table tests for some of the revision scaler tests #1677

Closed
glyn opened this issue Jul 25, 2018 · 1 comment
Closed

Use table tests for some of the revision scaler tests #1677

glyn opened this issue Jul 25, 2018 · 1 comment
Assignees
@tanzeeb
Labels
area/autoscale area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@glyn
Copy link
Contributor

glyn commented Jul 25, 2018 •
edited

pkg/autoscaler/revision_scaler_test.go should use table tests to reduce repetition.

Additional Info

/area autoscale
/area test-and-release
/kind cleanup
/label good first issue
@google-prow-robot google-prow-robot added area/autoscale area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 25, 2018
@glyn glyn mentioned this issue Jul 25, 2018
Closed
@tanzeeb
Copy link
Contributor

tanzeeb commented Jul 25, 2018

/assign

tanzeeb added a commit to tanzeeb/serving that referenced this issue Jul 25, 2018
@tanzeeb
Use table tests for revision scaler (knative#1677)
aed320d
@tanzeeb tanzeeb mentioned this issue Jul 25, 2018
Merged
@yolocs yolocs mentioned this issue Aug 1, 2018
Closed
dprotaso pushed a commit to tanzeeb/serving that referenced this issue Aug 8, 2018
@tanzeeb @dprotaso
Use table tests for revision scaler (knative#1677)
7c228cb
dprotaso pushed a commit to tanzeeb/serving that referenced this issue Aug 8, 2018
@tanzeeb @dprotaso
Use table tests for revision scaler (knative#1677)
ed637fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanzeeb tanzeeb

Labels
area/autoscale area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tanzeeb @glyn @mattmoor @google-prow-robot