Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Revision to corev1.Container #17

Closed
mattmoor opened this issue Jan 26, 2018 · 1 comment
Closed

Migrate Revision to corev1.Container #17

mattmoor opened this issue Jan 26, 2018 · 1 comment
Assignees
@drewinglis
Labels
kind/feature Well-understood/specified features, ready for coding.

Comments

@mattmoor
Copy link
Member

No description provided.

@mattmoor mattmoor added good first issue kind/feature Well-understood/specified features, ready for coding. labels Jan 26, 2018
@mattmoor
Copy link
Member Author

mattmoor commented Feb 5, 2018

Here's the TODO.

This was referenced Feb 14, 2018
Merged
Closed
drewinglis added a commit that referenced this issue Feb 14, 2018
@drewinglis
Update RevisionSpec to use corev1.Container instead of ContainerSpec (#…
7a787ef 
…174)

This was mostly a drop-in replacement, except that I updated the Env
specification to use corev1.Container.Env instead of being a top-level
field on RevisionSpec.

Fixes #17.
mgencur pushed a commit to mgencur/serving-1 that referenced this issue Dec 4, 2018
@openshift-merge-robot
Merge pull request knative#17 from mgencur/generate_dockerfiles
924b6bf 
Generate Dockerfiles
matzew pushed a commit to matzew/serving that referenced this issue May 2, 2019
@openshift-merge-robot
Merge pull request knative#17 from mgencur/generate_dockerfiles
3579538 
Generate Dockerfiles
tcnghia pushed a commit to tcnghia/serving that referenced this issue Jun 8, 2020
@mattmoor
Format markdown (knative#17)
ce7d377 
Produced via:
  `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`
/assign shashwathi tanzeeb
/cc shashwathi tanzeeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewinglis drewinglis

Labels
kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewinglis @mattmoor