Route controller ignoring config updates due to missing TypeMeta from informer

[jonjohnsonjr]

Expected Behavior

The Route controller should be reconciling on changes to Configurations.

Actual Behavior

The Route controller does not reconcile some Configuration changes because the change has a different ObjectReference representation in the tracker.

Steps to Reproduce the Problem

1. Create a RunLatest service
2. Upgrade knative/serving
3. Update the service to point to a new image

Additional Info

We use pkg/tracker to Track Configurations and Revisions that are referred to by Routes. The tracker ignores any updates for objects that we aren't tracking.

I believe the root cause here is that the configInformer's UpdateFunc and AddFunc are being called with different values, one missing TypeMeta. Instrumenting the tracker to print what's coming into OnChanged yields (at different times) both:

• OnChanged: {Configuration serving-tests pizzaplanet-upgrade-service serving.knative.dev/v1alpha1 }
• OnChanged: { serving-tests pizzaplanet-upgrade-service }

Note that the second value is missing APIVersion and Kind, thus they are different keys in the tracker's map, thus we miss updates from one.

I added some logging to when we track Configurations, and when the controller first comes up, I see:

{
  "level": "info",
  "ts": "2018-10-31T22:04:10.204Z",
  "logger": "controller.route-controller",
  "caller": "route/route.go:268",
  "msg": "Tracked: {Configuration serving-tests pizzaplanet-upgrade-service  serving.knative.dev/v1alpha1  }",
  "knative.dev/controller": "route-controller",
  "knative.dev/key": "serving-tests/pizzaplanet-upgrade-service"
}

So we will ignore any updates that are missing TypeMeta.

7 minutes later (triggered by a config-gc change it seems??), we see:

{
  "level": "info",
  "ts": "2018-10-31T22:11:21.012Z",
  "logger": "controller.configuration-controller.config-store",
  "caller": "configmap/store.go:166",
  "msg": "configuration config \"config-gc\" config was added or updated: &{24h0m0s 15h0m0s 1 5h0m0s}",
  "knative.dev/controller": "configuration-controller"
}
...
{
  "level": "info",
  "ts": "2018-10-31T22:11:21.018Z",
  "logger": "controller.route-controller",
  "caller": "route/route.go:268",
  "msg": "Tracked: { serving-tests pizzaplanet-upgrade-service    }",
  "knative.dev/controller": "route-controller",
  "knative.dev/key": "serving-tests/pizzaplanet-upgrade-service"
}

So we start finally tracking the un-TypeMeta'd version, which then causes the reconcile, and the route starts working again.

[mattmoor]

/area networking

[mattmoor]

/assign

[mattmoor]

@jonjohnsonjr also pointed me at this issue offline: kubernetes/apiextensions-apiserver#29