Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate and decide on framework to collect, process, publish Elafros stack-level telemetry #37

Closed
mchmarny opened this issue Jan 30, 2018 · 5 comments
Closed

Evaluate and decide on framework to collect, process, publish Elafros stack-level telemetry #37

mchmarny opened this issue Jan 30, 2018 · 5 comments
Assignees
@mdemirhan
Labels
area/monitoring kind/question Further information is requested

Comments

@mchmarny
Copy link
Member

At minimum, need aggregation data across K8s, Istio, and Elafros control plane

A couple of options to start with
@evankanderson
Copy link
Member

Possibly related:
#19
#20

Those items cover integrating logging/monitoring aggregation from the running code in Elafros to a collection system running either on-cluster or beside-cluster.

An ideal interface would be extensible (e.g. being able to run collectd or fluentd as collection sidecars based on cluster configuration).

@mchmarny mchmarny added the kind/question Further information is requested label Feb 3, 2018
@mdemirhan mdemirhan self-assigned this Feb 8, 2018
@mdemirhan
Copy link
Contributor

Please take a look at: https://docs.google.com/a/google.com/document/d/e/2PACX-1vQqPbeDaDyZNdeJpvqiNsn-CqtxrjkBWi8Ubms9kuNsPCKUoUWArnoCZqS7h9MFONAIyshHdWirFCwJ/pub

For comments & feedback, let's use Slack - #metrics channel.

@mdemirhan
Copy link
Contributor

Link above was not accessible by Pivotal. Please try the following: https://docs.google.com/document/d/1l44E-S9Dlnb6CrcwKeJDGjmXHA8TpxE-tYqio5qxxc8/edit?usp=sharing

@mattmoor mattmoor added this to the M3 milestone Mar 15, 2018
@grantr
Copy link
Contributor

grantr commented Mar 30, 2018

@mdemirhan can this be closed? Should it still be part of M3?

@mdemirhan
Copy link
Contributor

Yes, this can be closed. Thanks!

tcnghia pushed a commit to tcnghia/serving that referenced this issue Jun 8, 2020
@andrew-su @shashwathi
Update contour reconciler to use the update framework. (knative#37)
d3078bd 
* Update knative serving dependency

`dep ensure -update knative.dev/pkg knative.dev/serving`

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>

* Update contour reconciler

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>

* Update code-gen

* Clean up old commented out code

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>

* Revert changes for adding new reconciler event

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>

* Update vendor

- update reconciler with contour class name

Signed-off-by: Andrew Su <asu@pivotal.io>

* Update dependencies + codegen

`dep ensure -update knative.dev/pkg knative.dev/serving`
`./hack/update-codegen.sh`

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>

* Remove unnecessary code; handled by framework.

- No need to handle deletion timestamp
- Merged public and private Reconcile method

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>

Co-authored-by: Shashwathi <shashwathireddy@gmail.com>
skonto added a commit to skonto/serving that referenced this issue Dec 21, 2022
@openshift-cherrypick-robot @skonto
upgrade to v1beta1 (knative#37)
cef58e5 
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdemirhan mdemirhan

Labels
area/monitoring kind/question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@grantr @mchmarny @mattmoor @mdemirhan @evankanderson