Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for HTTP2 Server-Side Push #6003

Closed
tanzeeb opened this issue Nov 11, 2019 · 6 comments
Closed

Add e2e tests for HTTP2 Server-Side Push #6003

tanzeeb opened this issue Nov 11, 2019 · 6 comments
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@tanzeeb
Copy link
Contributor

tanzeeb commented Nov 11, 2019

In what area(s)?

/area networking
/area test-and-release
/kind good-first-issue

Describe the feature

The HTTP2 spec allows for server-side push, which allows the server to "push" resources to the client without an explicit request. We need an e2e test to ensure that this functionality works in Knative.

For more information on the feature, and how to implement it in Go, see this post:

https://blog.golang.org/h2push

@tanzeeb tanzeeb added the kind/feature Well-understood/specified features, ready for coding. label Nov 11, 2019
@knative-prow-robot knative-prow-robot added area/networking kind/good-first-issue area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Nov 11, 2019
@tanzeeb
Copy link
Contributor Author

tanzeeb commented Jan 14, 2020

/assign

@tanzeeb
Copy link
Contributor Author

tanzeeb commented Jan 16, 2020

Update: looks like push promises aren't yet supported by the the Go http/2 client.

This impacts both the ability to test the feature, and the actual support of the feature since the ReverseProxy in the Activator and Queue-Proxy both use the go http/2 client.

This story is blocked until golang/go#18594 is addressed.

/unassign

@knative-housekeeping-robot

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

@knative-prow-robot knative-prow-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 16, 2020
@knative-housekeeping-robot

Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle rotten

@knative-prow-robot knative-prow-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 16, 2020
@knative-housekeeping-robot

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

@knative-prow-robot
Copy link
Contributor

@knative-housekeeping-robot: Closing this issue.

In response to this:

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants