Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knative.dev/serving tests' Istio setup should be shared with knative.dev/net-istio #8896

Closed
tcnghia opened this issue Aug 3, 2020 · 4 comments
Closed

knative.dev/serving tests' Istio setup should be shared with knative.dev/net-istio #8896

tcnghia opened this issue Aug 3, 2020 · 4 comments
Assignees
@JRBANCEL
Labels
kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@tcnghia
Copy link
Contributor

tcnghia commented Aug 3, 2020

Describe the feature

Currently the Istio environment setup for knative.dev/serving integration tests and knative.dev/net-istio conformance tests are parallel. Worse, they have drifted, causing breakage like #8893 .

We need to figure out a better way to share the code setup between these two repositories to avoid these breakage.

cc @JRBANCEL @mattmoor @navidshaikh
@tcnghia tcnghia added the kind/feature Well-understood/specified features, ready for coding. label Aug 3, 2020
@tcnghia
Copy link
Contributor Author

tcnghia commented Aug 3, 2020

(a note about #8893 breakage: knative-extensions/net-istio#147 moved net-istio to use v1beta1 API, but test setups in knative.dev/serving and knative.dev/client are still using v1alpha3 API in their Istio setup)

@tcnghia tcnghia mentioned this issue Aug 3, 2020
Merged
@tcnghia
Copy link
Contributor Author

tcnghia commented Aug 4, 2020

cc @nak3

@nak3 nak3 mentioned this issue Aug 6, 2020
Closed
@tcnghia
Copy link
Contributor Author

tcnghia commented Aug 11, 2020

/assign @JRBANCEL

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2020
@nak3 nak3 mentioned this issue Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JRBANCEL JRBANCEL

Labels
kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcnghia @JRBANCEL