Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from Istio API v1alpha3 to v1beta1. #147

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Move from Istio API v1alpha3 to v1beta1. #147

merged 3 commits into from
Jul 27, 2020

Conversation

JRBANCEL
Copy link
Contributor

@JRBANCEL JRBANCEL commented Jun 16, 2020 •
edited
Loading

Title says it all: addresses #50

As far as I understand, v1beta1 is 100% the same shape as v1alpha3, so the transition should be transparent.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 16, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 16, 2020
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 17, 2020 •
edited
Loading

@JRBANCEL: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-net-istio-integration-tests 210fd10 link /test pull-knative-net-istio-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JRBANCEL JRBANCEL changed the title [WIP] Move from v1alpha3 to v1beta1 Move from Istio API v1alpha3 to v1beta1. Jun 17, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2020
@JRBANCEL
Copy link
Contributor Author

/assign @tcnghia @ZhiminXiang @nak3

@JRBANCEL
Copy link
Contributor Author

JRBANCEL commented Jun 17, 2020 •
edited
Loading

/hold
It seems a bit more complicated than anticipated.

  1. The E2E setup doesn't install v1beta1 CRD (needs Istio 1.5)
  2. We need to be supporting both versions at the same time

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-net-istio-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/ingress/ingress.go 80.5% 80.0% -0.5

@JRBANCEL
Copy link
Contributor Author

This is ready since v1beta1 is now installed.
/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2020
@tcnghia
Copy link
Contributor

tcnghia commented Jul 27, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JRBANCEL, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2020
@knative-prow-robot knative-prow-robot merged commit 8be8039 into knative-extensions:master Jul 27, 2020
@JRBANCEL JRBANCEL mentioned this pull request Jul 29, 2020
Closed
@tcnghia tcnghia mentioned this pull request Aug 3, 2020
Closed
tcnghia pushed a commit to tcnghia/net-istio that referenced this pull request Aug 3, 2020
Rollback knative-extensions#147
259670b
@tcnghia tcnghia mentioned this pull request Aug 3, 2020
Merged
knative-prow-robot pushed a commit that referenced this pull request Aug 3, 2020
@tcnghia
Rollback #147 (#203)
933aa6c
@nak3 nak3 mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chizhg chizhg Awaiting requested review from chizhg

@coryrc coryrc Awaiting requested review from coryrc

Assignees

@tcnghia tcnghia

@nak3 nak3

@ZhiminXiang ZhiminXiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JRBANCEL @knative-prow-robot @knative-metrics-robot @tcnghia @nak3 @ZhiminXiang @googlebot