Avoid adding gzip-encoding to requests implicitly #10691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go helpfully adds an Accept-Encoding: gzip header to requests by default, and silently uncompresses the response if it did so and the server added compression in response. While this is normally a good thing, in our case this means we silently add an extra "Accept-Encoding" header to requests before they get to the user container, and if the user container compresses the request in response we then pointlessly uncompress the response inside Queue Proxy. This commit picks up the new NewProxyAutoTransport method from pkg to avoid this behaviour.
knative-prow-robot
added
size/M
Codecov Report
@@ Coverage Diff @@
## master #10691 +/- ##
==========================================
+ Coverage 88.12% 88.17% +0.05%
==========================================
Files 186 186
Lines 8898 8898
==========================================
+ Hits 7841 7846 +5
+ Misses 815 813 -2
+ Partials 242 239 -3
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See knative/pkg#2006.
Go helpfully adds an Accept-Encoding: gzip header to requests by
default, and silently uncompresses the response if it did so and the
server added compression in response. While this is normally a good
thing, in our case this means we silently add an extra "Accept-Encoding"
header to requests before they get to the user container, and if the
user container compresses the request in response we end up pointlessly
uncompressing the just-compressed response inside Queue Proxy. This
commit picks up the new NewProxyAutoTransport method from pkg
to avoid this behaviour.
/assign @vagababov @markusthoemmes