New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v1beta1 version of DomainMapping crd #11682
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11682 +/- ##
==========================================
+ Coverage 87.81% 87.87% +0.05%
==========================================
Files 190 196 +6
Lines 9275 9360 +85
==========================================
+ Hits 8145 8225 +80
- Misses 878 883 +5
Partials 252 252
Continue to review full report at Codecov.
|
paging @dprotaso to the bat phone: looks like downgrade test is complaining about not being able to downgrade with this change because v1beta1 wouldn't be in the list of versions after downgrade but.. I think that's expected/inevitable when we introduce a new version? Probably missing something obvious, but do you happen to have a good trick for getting past this? /assign @dprotaso |
Leave |
aha thanks! let's give that a try |
neat, looked like that worked - thanks @dprotaso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: copyright date should be 2021
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, julz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks like generated clients still have the old copyright date |
heh oops, forgot to rebase on my own change :). done |
existing unrelated flake (#11653) /retest |
/lgtm |
Adds a v1beta1 version of the DomainMapping CRD and a corresponding group in api + conformance test subdirectory. Also adds the new group to the webhook. I think I'm holding this right, but please review carefully 馃槄.