Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1beta1 version of DomainMapping crd #11682

Merged
merged 5 commits into from Jul 23, 2021

Conversation

julz
Copy link
Member

@julz julz commented Jul 15, 2021

Adds a v1beta1 version of the DomainMapping CRD and a corresponding group in api + conformance test subdirectory. Also adds the new group to the webhook. I think I'm holding this right, but please review carefully 馃槄.

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 15, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #11682 (fb35e17) into main (0e98289) will increase coverage by 0.05%.
The diff coverage is 90.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11682      +/-   ##
==========================================
+ Coverage   87.81%   87.87%   +0.05%     
==========================================
  Files         190      196       +6     
  Lines        9275     9360      +85     
==========================================
+ Hits         8145     8225      +80     
- Misses        878      883       +5     
  Partials      252      252              
Impacted Files Coverage 螖
...kg/apis/serving/v1beta1/domainmapping_lifecycle.go 81.81% <81.81%> (酶)
pkg/apis/serving/v1beta1/conversion_error.go 100.00% <100.00%> (酶)
pkg/apis/serving/v1beta1/domainmapping_defaults.go 100.00% <100.00%> (酶)
pkg/apis/serving/v1beta1/domainmapping_types.go 100.00% <100.00%> (酶)
...g/apis/serving/v1beta1/domainmapping_validation.go 100.00% <100.00%> (酶)
pkg/apis/serving/v1beta1/register.go 100.00% <100.00%> (酶)
pkg/reconciler/configuration/configuration.go 86.15% <0.00%> (-0.77%) 猬囷笍
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0e98289...fb35e17. Read the comment docs.

@julz
Copy link
Member Author

julz commented Jul 15, 2021

paging @dprotaso to the bat phone: looks like downgrade test is complaining about not being able to downgrade with this change because v1beta1 wouldn't be in the list of versions after downgrade but.. I think that's expected/inevitable when we introduce a new version? Probably missing something obvious, but do you happen to have a good trick for getting past this?

/assign @dprotaso

@dprotaso
Copy link
Member

dprotaso commented Jul 15, 2021

Jul 15 11:10:08.393 install_latest_release [OUT] kapp: Error: Applying update customresourcedefinition/domainmappings.serving.knative.dev (apiextensions.k8s.io/v1) cluster:
1884
Jul 15 11:10:08.393 install_latest_release [OUT]   Updating resource customresourcedefinition/domainmappings.serving.knative.dev (apiextensions.k8s.io/v1) cluster:
1885
Jul 15 11:10:08.393 install_latest_release [OUT]     CustomResourceDefinition.apiextensions.k8s.io "domainmappings.serving.knative.dev" is invalid: status.storedVersions[1]:
1886
Jul 15 11:10:08.393 install_latest_release [OUT]       Invalid value: "v1beta1": must appear in spec.versions (reason: Invalid)

Leave v1alpha1 as the storage version for a release I believe

@julz
Copy link
Member Author

julz commented Jul 15, 2021

Leave v1alpha1 as the storage version for a release I believe

aha thanks! let's give that a try

@julz
Copy link
Member Author

julz commented Jul 15, 2021

neat, looked like that worked - thanks @dprotaso

@julz julz changed the title WIP: Add v1beta1 version of DomainMapping crd Add v1beta1 version of DomainMapping crd Jul 15, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2021
Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: copyright date should be 2021

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

dprotaso commented Jul 18, 2021

looks like generated clients still have the old copyright date

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021
@julz
Copy link
Member Author

julz commented Jul 19, 2021

looks like generated clients still have the old copyright date

heh oops, forgot to rebase on my own change :). done

@julz
Copy link
Member Author

julz commented Jul 19, 2021

existing unrelated flake (#11653)

/retest

@dprotaso
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@knative-prow-robot knative-prow-robot merged commit 5a51323 into knative:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants