WIP: Allow 502 codes as well as 503

[julz]

WIP: Letting prow run the tests with this.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [julz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[julz]

/test

[knative-prow-robot]

@julz: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test pull-knative-serving-build-tests
• /test pull-knative-serving-unit-tests
• /test pull-knative-serving-upgrade-tests
• /test pull-knative-serving-istio-stable-no-mesh
• /test pull-knative-serving-istio-stable-no-mesh-tls
• /test pull-knative-serving-kourier-stable
• /test pull-knative-serving-kourier-stable-tls
• /test pull-knative-serving-contour-latest
• /test pull-knative-serving-contour-tls

The following commands are available to trigger optional jobs:

• /test pull-knative-serving-istio-latest-mesh
• /test pull-knative-serving-istio-latest-mesh-short
• /test pull-knative-serving-istio-latest-mesh-tls
• /test pull-knative-serving-istio-latest-no-mesh
• /test pull-knative-serving-istio-latest-no-mesh-tls
• /test pull-knative-serving-istio-stable-mesh
• /test pull-knative-serving-istio-stable-mesh-short
• /test pull-knative-serving-istio-stable-mesh-tls
• /test pull-knative-serving-istio-stable-no-mesh-tls-with-http01
• /test pull-knative-serving-ambassador-latest
• /test pull-knative-serving-ambassador-latest-tls
• /test pull-knative-serving-kong-latest
• /test pull-knative-serving-kong-latest-tls
• /test pull-knative-serving-https

Use /test all to run the following jobs that were automatically triggered:

• pull-knative-serving-build-tests
• pull-knative-serving-unit-tests
• pull-knative-serving-upgrade-tests
• pull-knative-serving-istio-stable-no-mesh
• pull-knative-serving-istio-stable-no-mesh-tls

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[julz]

/test pull-knative-serving-istio-stable-mesh-short
/test pull-knative-serving-istio-latest-mesh-short

[codecov]

Codecov Report

Merging #11900 (6bf1d06) into main (68dba4a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #11900   +/-   ##
=======================================
  Coverage   87.70%   87.71%           
=======================================
  Files         196      197    +1     
  Lines        9430     9467   +37     
=======================================
+ Hits         8271     8304   +33     
- Misses        897      900    +3     
- Partials      262      263    +1     

Impacted Files	Coverage Δ
cmd/queue/main.go	0.50% <0.00%> (-0.02%)	⬇️
pkg/activator/net/revision_backends.go	92.41% <0.00%> (ø)
pkg/queue/concurrency_state.go	87.87% <0.00%> (ø)
pkg/reconciler/configuration/configuration.go	86.15% <0.00%> (+1.53%)	⬆️
pkg/autoscaler/scaling/multiscaler.go	89.09% <0.00%> (+1.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68dba4a...6bf1d06. Read the comment docs.

[knative-prow-robot]

@julz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
pull-knative-serving-build-tests	6bf1d06	link	/test pull-knative-serving-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[julz]

seeing autoscale_hpa_test.go:220: Waiting for hpa.status is available: {<nil> <nil> 1 0 [] [{AbleToScale True 2021-09-02 09:29:17 +0000 UTC SucceededGetScale the HPA controller was able to get the target's current scale} {ScalingActive False 2021-09-02 09:29:18 +0000 UTC FailedGetResourceMetric the HPA was unable to compute the replica count: failed to get cpu utilization: unable to get metrics for resource cpu: no metrics returned from resource metrics API}]} in the logs for the failure above, suspect this is an unrelated problem.

/test pull-knative-serving-istio-latest-mesh-short

[mayuchau]

Hello,
I am referring this document to build knative-serving to get images from source code.
https://github.com/knative/serving/blob/main/DEVELOPMENT.md

I have configured go, ko tools properly.

$ go version
go version go1.17 linux/amd64

$ ko version
0.8.3

In the Deploy knative-serving stage when am trying below ko command nothing is happening. (I waited more than 5 - 10 minutes)

ko apply --selector knative.dev/crd-install=true -Rf config/core/
I have tried below command as well, but for both of them I am seeing the same behavior.

ko resolve -Rf config/core

[mayuchau]

after waiting for more than 10 mins I am seeing below error message.

`$ ko apply --selector knative.dev/crd-install=true -Rf config/core/

2021/09/06 05:13:23 NOTICE!

ko and go have mismatched GOROOT:
go/build.Default.GOROOT = "go"
$(go env GOROOT) = "/usr/local/go"

Inferring GOROOT="/usr/local/go"

Run this to remove this warning:
export GOROOT=$(go env GOROOT)

For more information see:
ko-build/ko#106

2021/09/06 05:13:23 No matching credentials were found, falling back on anonymous
customresourcedefinition.apiextensions.k8s.io/images.caching.internal.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/certificates.networking.internal.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/configurations.serving.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/clusterdomainclaims.networking.internal.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/domainmappings.serving.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/ingresses.networking.internal.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/metrics.autoscaling.internal.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/podautoscalers.autoscaling.internal.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/revisions.serving.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/routes.serving.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/serverlessservices.networking.internal.knative.dev unchanged
customresourcedefinition.apiextensions.k8s.io/services.serving.knative.dev unchanged
[mayuchau@phoenix61861 serving]$ export GOROOT=$(go env GOROOT)
[mayuchau@phoenix61861 serving]$ ko apply --selector knative.dev/crd-install=true -Rf config/core/
`

as per the recommendation I am exporting GOROOT but again I am seeing same issue.

export GOROOT=$(go env GOROOT)

[julz]

Hi @mayuchau - not sure what's going on with your build environment (that may be a question to raise over at http://github.com/google/ko), but knative/networking#494 should have bubbled its way in to the nightly releases now, so you can likely do:

kubectl apply -f https://storage.googleapis.com/knative-nightly/serving/latest/serving-core.yaml

[julz]

this PR did its job, and the changes have landed via knative/networking#494 and #11901 - closing

/close

[knative-prow-robot]

@julz: Closed this PR.

In response to this:

this PR did its job, and the changes have landed via knative/networking#494 and #11901 - closing

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.