New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not append the port to authority #12350
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12350 +/- ##
==========================================
+ Coverage 87.46% 87.48% +0.02%
==========================================
Files 195 195
Lines 9644 9644
==========================================
+ Hits 8435 8437 +2
+ Misses 929 926 -3
- Partials 280 281 +1
Continue to review full report at Codecov.
|
/test pull-knative-serving-https |
/test pull-knative-serving-https |
/test pull-knative-serving-https |
/cc @markusthoemmes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch stops to append the port to authority header for gRPC test.
grpc-go recently added the validation for aurhority and server name by grpc/grpc-go#4817
and the host with port in authority gets the following matching error:
This patch fixes it.