Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dev container and updates docs with Codespaces information #13838

Conversation

samruddhikhandale
Copy link
Contributor

@samruddhikhandale samruddhikhandale commented Mar 31, 2023

Reference: #13806

image

You can test these changes with Codespaces by simply clicking on the Code icon on top right side of this PR ☝️

Release Note

NONE

Signed-off-by: Samruddhi Khandale <samruddhikhandale@github.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: samruddhikhandale / name: Samruddhi Khandale (3be4321)

@knative-prow
Copy link

knative-prow bot commented Mar 31, 2023

Welcome @samruddhikhandale! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot requested review from carlisia and kauana March 31, 2023 16:34
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 31, 2023

Hi @samruddhikhandale. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ef53449) 86.29% compared to head (ac6ed11) 86.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13838   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files         198      198           
  Lines       14669    14669           
=======================================
  Hits        12659    12659           
+ Misses       1713     1712    -1     
- Partials      297      298    +1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

DEVELOPMENT.md Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2023
.devcontainer/setup.sh Show resolved Hide resolved
.devcontainer/docker-start.sh Outdated Show resolved Hide resolved
@dprotaso
Copy link
Member

dprotaso commented Apr 4, 2023

Looks good - just one last minor thing

#13838 (comment)

@dprotaso
Copy link
Member

dprotaso commented Apr 6, 2023

great thanks for the help!

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, samruddhikhandale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@knative-prow knative-prow bot merged commit 8f273e4 into knative:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants