Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default domain to cluster's domain #13964

Merged
merged 1 commit into from May 15, 2023
Merged

Set default domain to cluster's domain #13964

merged 1 commit into from May 15, 2023

Conversation

kauana
Copy link
Member

@kauana kauana commented May 9, 2023 •
edited by dprotaso

Fixes #13955

Proposed Changes

  • Sets DefaultDomain to cluster's domain instead of hardcoded svc.cluster.local

Release Note

Sets DefaultDomain to cluster's domain instead of hardcoded `svc.cluster.local`

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/API API objects and controllers labels May 9, 2023
@knative-prow knative-prow bot requested review from ReToCode and skonto May 9, 2023 02:45
@knative-prow knative-prow bot added area/networking size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2023
@kauana kauana force-pushed the default-domain-improvement branch 2 times, most recently from a080da6 to 1fce1c3 Compare May 9, 2023 04:59
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2023
@kauana kauana changed the title Set default domain to cluster's domain Draft: Set default domain to cluster's domain May 9, 2023
@dprotaso dprotaso changed the title Draft: Set default domain to cluster's domain [WIP] Set default domain to cluster's domain May 9, 2023
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2023
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (219285e) 86.19% compared to head (8a307b6) 86.21%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13964      +/-   ##
==========================================
+ Coverage   86.19%   86.21%   +0.02%     
==========================================
  Files         199      199              
  Lines       14759    14759              
==========================================
+ Hits        12722    12725       +3     
+ Misses       1735     1733       -2     
+ Partials      302      301       -1
Impacted Files Coverage Δ
pkg/reconciler/route/config/domain.go 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kauana kauana changed the title [WIP] Set default domain to cluster's domain Set default domain to cluster's domain May 11, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2023
@kauana
Copy link
Member Author

kauana commented May 11, 2023

/assign @dprotaso

@kauana
Copy link
Member Author

kauana commented May 11, 2023

/retest

Set default domain to cluster's domain
8a307b6 
- Set default domain to cluster's domain
@kauana kauana force-pushed the default-domain-improvement branch from e105306 to 8a307b6 Compare May 12, 2023 00:01
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 12, 2023
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@knative-prow
Copy link

knative-prow bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kauana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@knative-prow knative-prow bot merged commit 99800ed into knative:main May 15, 2023
62 checks passed
@kauana kauana deleted the default-domain-improvement branch July 11, 2023 18:21
skonto pushed a commit to skonto/serving that referenced this pull request Oct 5, 2023
@skonto
Set default domain to cluster's domain (knative#13964)
c2a810e 
- Set default domain to cluster's domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@ReToCode ReToCode Awaiting requested review from ReToCode

@skonto skonto Awaiting requested review from skonto

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DefaultDomain should be the cluster's domain and not hardcoded to svc.cluster.local
2 participants
@kauana @dprotaso