Test istio with system-internal-tls enabled

[ReToCode]

Fixes knative-extensions/net-istio#1063

Changes

• Adds istio with system-internal-tls enabled to test matrix
• Runs the system-internal-tls tests for istio

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1940e5a) 86.01% compared to head (f8f6af4) 86.01%.

❗ Current head f8f6af4 differs from pull request most recent head 0a5a698. Consider uploading reports for the commit 0a5a698 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14494   +/-   ##
=======================================
  Coverage   86.01%   86.01%           
=======================================
  Files         197      197           
  Lines       14915    14915           
=======================================
  Hits        12829    12829           
  Misses       1776     1776           
  Partials      310      310           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nak3]

Could you also try to enable this

serving/test/e2e/systeminternaltls/system_internal_tls_test.go

Lines 47 to 49 in ea603c9

	if !(strings.Contains(test.ServingFlags.IngressClass, "kourier") || strings.Contains(test.ServingFlags.IngressClass, "contour")) {
	t.Skip("Skip this test for non-kourier or non-contour ingress.")
	}

?

[ReToCode]

Could you also try to enable this

Done, let's see if that works. I also changed the if to avoid having all not-cases in there.

[ReToCode]

/test istio-latest-no-mesh

[ReToCode]

@nak3 looks good with the test enabled. I'll update this PR here to be able to merge once the net-istio PR is merged.

[ReToCode]

/hold for knative-extensions/net-istio#1085 to be merged and bumped in Serving

[nak3]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ReToCode,nak3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ReToCode]

/retest

[ReToCode]

/retest

[ReToCode]

/unhold

[ReToCode]

Rebased to have net-istio changes in, @nak3 can you approve again?

[nak3]

/lgtm