Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] Bound buffer for reading stats #14541

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #14523

Applied an upper bound to the statistics data read from the queue-proxy by the autoscaler.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1c0fa5d) 86.23% compared to head (3f81c34) 86.24%.
Report is 1 commits behind head on release-1.10.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.10   #14541   +/-   ##
=============================================
  Coverage         86.23%   86.24%           
=============================================
  Files               199      199           
  Lines             14766    14768    +2     
=============================================
+ Hits              12734    12736    +2     
  Misses             1731     1731           
  Partials            301      301           
Files Coverage Δ
pkg/autoscaler/metrics/http_scrape_client.go 93.02% <100.00%> (+7.65%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 19, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@knative-prow knative-prow bot merged commit 101f814 into knative:release-1.10 Oct 19, 2023
61 checks passed
openshift-ci bot pushed a commit to openshift-knative/serving that referenced this pull request Oct 20, 2023
* Min TLS for tag to digest defaults to 1.2 again and is configurable (knative#13963)

quay.io only supports 1.2

Co-authored-by: dprotaso <dprotaso@gmail.com>

* drop safe to evict annotations (knative#14051)

this prevents nodes from draining

Co-authored-by: dprotaso <dprotaso@gmail.com>

* [release-1.10] RandomChoice 2 policy wasn't random when the number of targets is 2 (with equal weight) (knative#14052)

* RandomChoice 2 policy wasn't random when the number of targets is 2

* fix linting

---------

Co-authored-by: dprotaso <dprotaso@gmail.com>

* [release-1.10] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14377)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

* fix perms

---------

Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Dave Protasowski <dprotaso@gmail.com>

* Leave a comment which will trigger a new dot release (knative#14501)

* [release-1.10] bump x/net to v0.17 (knative#14517)

* [release-1.10] bump x/net to v0.17

* Re-generate test/config/tls/cert-secret.yaml (knative#14324)

* Run hack/upgrade

* Bound buffer for reading stats (knative#14541)

Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>

---------

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: dprotaso <dprotaso@gmail.com>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants