Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set AppProtocol on Services #14757

Merged
merged 5 commits into from Jan 12, 2024
Merged

Set AppProtocol on Services #14757

merged 5 commits into from Jan 12, 2024

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Jan 3, 2024 •
edited by dprotaso

Part of #14569

Depends on knative/networking#904

Proposed Changes

  • sets AppProtocol to "kubernetes.io/h2c" on Services when applicable

Release Note

TBD

@knative-prow knative-prow bot added area/API API objects and controllers size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/networking labels Jan 3, 2024
@knative-prow knative-prow bot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52b3d0c) 86.02% compared to head (fe7f339) 86.01%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14757      +/-   ##
==========================================
- Coverage   86.02%   86.01%   -0.01%     
==========================================
  Files         197      197              
  Lines       14945    14950       +5     
==========================================
+ Hits        12856    12859       +3     
- Misses       1778     1780       +2     
  Partials      311      311

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KauzClay
Copy link
Contributor Author

KauzClay commented Jan 4, 2024

/test istio-latest-no-mesh-tls

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2024
andrew-su
andrew-su reviewed Jan 9, 2024
View reviewed changes
go.mod Outdated
@@ -162,3 +162,5 @@ require (

// TODO: https://github.com/knative/serving/issues/14597
replace github.com/gorilla/websocket => github.com/gorilla/websocket v1.5.0

replace knative.dev/networking v0.0.0-20231219131858-8c7897c8b9a0 => github.com/KauzClay/networking v0.0.0-20240103183713-99c292ac8072
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the changes you need from github.com/KauzClay/networking go to knative.dev/networking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I actually have another PR open with them here: knative/networking#904

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was just a way to get the PR tests to run with those changes, and see if I was breaking anything major in serving

@KauzClay KauzClay marked this pull request as draft January 9, 2024 17:34
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2024
@KauzClay KauzClay mentioned this pull request Jan 10, 2024
Merged
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2024
@KauzClay KauzClay marked this pull request as ready for review January 11, 2024 13:39
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2024
@dprotaso
Copy link
Member

You'll need to rebase - looks like the networking deps change came in through another PR

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KauzClay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@dprotaso
Copy link
Member

Let's merge this in - but I think in the future when a Gateway implementation lands a change that we can test we'll have to change what we do here.

H2C - is H2 Prior Knowledge over clear text which isn't the same as an HTTP/1 Upgrade with the h2c nonce. So I wonder if we'll want to label things as http/1 (empty) and only put h2c when it's explicitly done by the user.

Let's revisit this when we have a gateway implementation that supports that this feature.

@dprotaso
Copy link
Member

I changed the PR body not say 'fixes' to 'part of' - I'd like to verify this before we close out that issue.

@knative-prow knative-prow bot merged commit e5602d7 into knative:main Jan 12, 2024
55 checks passed
KauzClay added a commit to KauzClay/serving that referenced this pull request Jan 17, 2024
@KauzClay
Revert "Set AppProtocol on Services (knative#14757)"
c4b51b6 
This reverts commit e5602d7.
@KauzClay KauzClay mentioned this pull request Jan 17, 2024
Merged
knative-prow bot pushed a commit that referenced this pull request Jan 17, 2024
@KauzClay
Revert "Set AppProtocol on Services (#14757)" (#14805)
ad0a989 
This reverts commit e5602d7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-su andrew-su andrew-su left review comments

@kauana kauana Awaiting requested review from kauana

@xtreme-vikram-yadav xtreme-vikram-yadav Awaiting requested review from xtreme-vikram-yadav

@evankanderson evankanderson Awaiting requested review from evankanderson

@jsanin-vmw jsanin-vmw Awaiting requested review from jsanin-vmw

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KauzClay @dprotaso @andrew-su @knative-prow-robot