Replaces all deprecated usages of sets with new generic versions #14765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumping knative.dev/networking a34a5c5...7cca4b0: > 7cca4b0 upgrade to latest dependencies (# 906) > f3897c7 Update community files (# 905) bumping knative.dev/hack 7030d5b...3ea694d: > 3ea694d include additional k8s bash file when updating exec permission (# 357) > 2f27d6e Update community files (# 356) bumping knative.dev/pkg 697d669...de3e9cc: > de3e9cc Fixing all deprecated use of sets.String (# 2915) > a65a9e2 lower log level for AdmissionController.Admit validation failures (# 2905) > 4c06610 Update community files (# 2929) bumping knative.dev/caching 750d082...d66e24d: > d66e24d upgrade to latest dependencies (# 818) > 4e97aeb Update community files (# 817) Signed-off-by: Knative Automation <automation@knative.team>
knative-prow
bot
added
do-not-merge/hold
knative-prow
bot
requested review from
evankanderson,
KauzClay and
xtreme-vikram-yadav
knative-prow
bot
added
area/autoscale
area/networking
area/test-and-release
This was referenced Jan 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14765 +/- ##
=======================================
Coverage 86.03% 86.03%
=======================================
Files 197 197
Lines 14937 14937
=======================================
Hits 12851 12851
Misses 1776 1776
Partials 310 310 ☔ View full report in Codecov by Sentry. |
ReToCode
force-pushed
the
bump-deps-with-string-set
branch
from
6d1234f
to
9a1c89f
Compare
ReToCode
changed the title
|
/unhold |
knative-prow
bot
added
size/XXL
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
setswith new generic versions/kind cleanup
Partially #14692
/hold networking would need to be merged first