Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change private K8s service to be a headless service #15170

Merged
merged 2 commits into from May 16, 2024

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented Apr 29, 2024

Related to #13201

Proposed Changes

  • change private K8s service to be a headless service

Release Note

The Private Kubernetes service has been transitioned to a headless service, resulting in the freeing up of an iptable entry on a node.

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto April 29, 2024 22:00
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (c2d0af1) to head (6bd9a10).
Report is 109 commits behind head on main.

Current head 6bd9a10 differs from pull request most recent head 5a97964

Please upload reports for the commit 5a97964 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15170      +/-   ##
==========================================
+ Coverage   84.11%   84.75%   +0.64%     
==========================================
  Files         213      218       +5     
  Lines       16783    13470    -3313     
==========================================
- Hits        14117    11417    -2700     
+ Misses       2315     1684     -631     
- Partials      351      369      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg izabelacg changed the title [WIP] change private K8s service to be a headless service change private K8s service to be a headless service May 13, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@izabelacg
Copy link
Member Author

/hold for review

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
Copy link

knative-prow bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@knative-prow knative-prow bot merged commit 3b35f54 into knative:main May 16, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants