Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CORS tests from serving #15249

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

izabelacg
Copy link
Member

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 24, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto May 24, 2024 18:47
@dprotaso
Copy link
Member

/lgtm
/approve

/override “style / suggester / shell”

Copy link

knative-prow bot commented May 24, 2024

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /
  • shell”
  • suggester
  • “style

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-tests_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_serving_main
  • upgrade-tests_serving_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/lgtm
/approve

/override “style / suggester / shell”

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
Copy link

knative-prow bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@dprotaso
Copy link
Member

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/override "style / suggester / shell"

Copy link

knative-prow bot commented May 24, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/retest

@knative-prow knative-prow bot merged commit 79da324 into knative:main May 24, 2024
66 of 67 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request could not be created: failed to create pull request against knative/serving#release-1.14 from head knative-prow-robot:cherry-pick-15249-to-release-1.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between knative:release-1.14 and knative-prow-robot:cherry-pick-15249-to-release-1.14"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request could not be created: failed to create pull request against knative/serving#release-1.14 from head knative-prow-robot:cherry-pick-15249-to-release-1.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between knative:release-1.14 and knative-prow-robot:cherry-pick-15249-to-release-1.14"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

oh nm - this isn't in the 1.14 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants