Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests to validate uptime of services during user pod deletion #15284

Merged
merged 15 commits into from
Jun 25, 2024
Merged

add tests to validate uptime of services during user pod deletion #15284

merged 15 commits into from
Jun 25, 2024

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented May 30, 2024 •
edited
Loading

Proposed Changes

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto May 30, 2024 21:00
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (8cf5aba) to head (8eb0386).
Report is 41 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15284      +/-   ##
==========================================
- Coverage   84.76%   84.49%   -0.27%     
==========================================
  Files         218      219       +1     
  Lines       13482    13548      +66     
==========================================
+ Hits        11428    11448      +20     
- Misses       1687     1731      +44     
- Partials      367      369       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg izabelacg changed the title [WIP] add tests to validate uptime of services during user pod deletion add tests to validate uptime of services during user pod deletion Jun 3, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2024
@izabelacg
Copy link
Member Author

/retest

dprotaso
dprotaso reviewed Jun 4, 2024
View reviewed changes
test/ha/resilience_test.go Outdated Show resolved Hide resolved
test/ha/resilience_test.go Outdated Show resolved Hide resolved
test/ha/resilience_test.go Outdated Show resolved Hide resolved
test/ha/resilience_test.go Outdated Show resolved Hide resolved
test/ha/resilience_test.go Outdated Show resolved Hide resolved
test/ha/resilience_test.go Outdated Show resolved Hide resolved
skonto
skonto reviewed Jun 5, 2024
View reviewed changes
test/ha/workload_test.go Outdated Show resolved Hide resolved
dprotaso
dprotaso reviewed Jun 5, 2024
View reviewed changes
test/ha/workload_test.go Outdated Show resolved Hide resolved
@izabelacg
Copy link
Member Author

/retest

@izabelacg
Copy link
Member Author

/test contour-latest

@izabelacg
Copy link
Member Author

/test contour-latest

@izabelacg
Copy link
Member Author

/retest

@izabelacg
Copy link
Member Author

/test contour-latest

@izabelacg
Copy link
Member Author

@dprotaso tests are no longer timing out after decreasing the repetitionCount to 5

skonto
skonto reviewed Jun 19, 2024
View reviewed changes
test/e2e-tests.sh Outdated
@@ -153,7 +153,7 @@ toggle_feature secure-pod-defaults Disabled

# Run HA tests separately as they're stopping core Knative Serving pods.
# Define short -spoofinterval to ensure frequent probing while stopping pods.
go_test_e2e -timeout=25m -failfast -parallel=1 ./test/ha \
go_test_e2e -timeout=40m -failfast -parallel=1 ./test/ha \
Copy link
Contributor

@skonto skonto Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the timeout smaller or this is the lower bound for test to pass. I see that:

PASS test/ha.TestActivatorNotInRequestPath (326.48s)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried 25m as it was before, but the test times out. I'll incrementally increase to find out the lower bound for it to pass

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tests take somewhere between 25 and 30min, so changed it to 30min

@dprotaso
Copy link
Member

/retest

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@knative-prow knative-prow bot merged commit 2ac8b35 into knative:main Jun 25, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@skonto skonto skonto left review comments

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@izabelacg @dprotaso @skonto