Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-gateway-api nightly #15337

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-gateway-api.yaml istio-gateway.yaml contour-gateway.yaml gateway-api.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-gateway-api/latest/$x > ${GITHUB_WORKSPACE}/./third_party/gateway-api-latest/$x
done

Details:

bumping knative.dev/net-gateway-api cf4988a...e60bf61:
  > e60bf61 bump istio, contour & gateway deps (# 745)

Copy link

knative-prow bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.52%. Comparing base (b22e06c) to head (c631039).

Current head c631039 differs from pull request most recent head 9464451

Please upload reports for the commit 9464451 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15337      +/-   ##
==========================================
- Coverage   84.55%   84.52%   -0.03%     
==========================================
  Files         219      219              
  Lines       13548    13548              
==========================================
- Hits        11455    11452       -3     
- Misses       1726     1728       +2     
- Partials      367      368       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Jun 20, 2024

{Failed  === RUN   TestDestroyPodInflight

cc @dprotaso @izabelacg

See also #15340 (comment).
Is there anything beyond Contour that could create the fail.

@skonto
Copy link
Contributor

skonto commented Jun 20, 2024

/test gateway-api-latest

@skonto
Copy link
Contributor

skonto commented Jun 20, 2024

/test gateway-api-latest-and-contour

@dprotaso
Copy link
Member

Is there anything beyond Contour that could create the fail.

I haven't dug into it - it's a flake to investigate

@dprotaso
Copy link
Member

For Contour it just didn't work because disabling timeouts didn't work

@skonto
Copy link
Contributor

skonto commented Jun 20, 2024

/test gateway-api-latest

1 similar comment
@skonto
Copy link
Contributor

skonto commented Jun 21, 2024

/test gateway-api-latest

@skonto
Copy link
Contributor

skonto commented Jun 21, 2024

Failed again.

@skonto
Copy link
Contributor

skonto commented Jun 21, 2024

TestGRPCAutoscaleUpDownUp

@skonto
Copy link
Contributor

skonto commented Jun 21, 2024

/test gateway-api-latest

@skonto
Copy link
Contributor

skonto commented Jun 21, 2024

    grpc_test.go:433: Error : error processing requests ping gRPC error: could not send request: rpc error: code = Unavailable desc = error reading from server: EOF

bumping knative.dev/net-gateway-api cf4988a...e60bf61:
  > e60bf61 bump istio, contour & gateway deps (# 745)

Signed-off-by: Knative Automation <automation@knative.team>
Copy link

knative-prow bot commented Jun 21, 2024

@knative-automation: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gateway-api-latest-and-contour_serving_main 9464451 link false /test gateway-api-latest-and-contour

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knative-prow knative-prow bot merged commit a5ad85b into knative:main Jun 21, 2024
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants