Only set Latest to LatestCreated revision #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Feb 14, 2018
| @@ -437,7 +441,10 @@ func (c *Controller) markConfigurationReady( | |||
| Status: corev1.ConditionTrue, | |||
| Reason: "LatestRevisionReady", | |||
| }) | |||
|
|
|||
| glog.Infof("Seting Latest of Configuration %q to revision %q", config.Name, revision.Name) | |||
| config.Status.Latest = revision.Name | |||
There was a problem hiding this comment.
Can we rename Latest to LatestReady. I think this was a misnomer that we corrected in the API draft that was never reflected here.
mattmoor
approved these changes
Feb 14, 2018
lberk
pushed a commit
to lberk/serving
that referenced
this pull request
Jul 4, 2019
Update ci config script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ready revision is not the latest created one, we should not set it to
Configuration.Status.Latest. Fixes #77.