Clean up some of the reconcilation testing infrastructure #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dprotaso
commented
Sep 5, 2018
dprotaso
commented
- extract out a generic object sorter from a specific lister
- move the API typed lister to a separate subpackage under v1alpha1/testing
- clean up readability of the API for extracting actions
- use go aliasing help with readability now that we have two packages
knative-prow-robot
added
the
size/XL
dprotaso
force-pushed
the
reconciler-testing-separation
branch
from
5accfc5
to
584d94a
Compare
- extract out a generic object sorter from a specific lister - move the API typed lister to a separate subpackage under v1alpha1/testing - clean up readability of the API for extracting actions - use go aliasing help with readability now that we have two packages
dprotaso
force-pushed
the
reconciler-testing-separation
branch
from
584d94a
to
4d62c45
Compare
|
/test all |
|
/test pull-knative-serving-integration-tests |
|
cc @jonjohnsonjr Who was thinking of a similar split of some logic into /lgtm Thanks, @dprotaso I definitely think this cleans things up. I look forward to more :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/test pull-knative-serving-integration-tests |
1 similar comment
|
/test pull-knative-serving-integration-tests |
dprotaso
pushed a commit
to dprotaso/serving
that referenced
this pull request
Jan 11, 2021
bumping knative.dev/hack 4ed1ecb...ea9c9a0: > ea9c9a0 Add hermetic go mod aware handling to run_go_tool (knative#38) bumping knative.dev/pkg 51c72e2...93874f0: > 93874f0 Drainer supports customized kubelet probe check (knative#1977) bumping knative.dev/networking ecb89ce...c30dc94: > c30dc94 Use symlink for testdata version of config-network.yaml (knative#328) Signed-off-by: Knative Automation <automation@knative.team>
dprotaso
pushed a commit
to dprotaso/serving
that referenced
this pull request
Jan 11, 2021
``` bumping knative.dev/hack 4ed1ecb...ea9c9a0: > ea9c9a0 Add hermetic go mod aware handling to run_go_tool (knative#38) bumping knative.dev/networking ecb89ce...c30dc94: > c30dc94 Use symlink for testdata version of config-network.yaml (knative#328) bumping knative.dev/pkg 51c72e2...93874f0: > 93874f0 Drainer supports customized kubelet probe check (knative#1977) ``` Signed-off-by: Knative Automation <automation@knative.team>
dprotaso
pushed a commit
to dprotaso/serving
that referenced
this pull request
Jan 12, 2021
bumping knative.dev/hack 4ed1ecb...ea9c9a0: > ea9c9a0 Add hermetic go mod aware handling to run_go_tool (knative#38) bumping knative.dev/networking ecb89ce...3a89509: > 3a89509 As per discussion with @mattmoor keep drainer in pkg (knative#329) > c30dc94 Use symlink for testdata version of config-network.yaml (knative#328) bumping knative.dev/pkg 51c72e2...93874f0: > 93874f0 Drainer supports customized kubelet probe check (knative#1977) Signed-off-by: Knative Automation <automation@knative.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.