Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fix markdown lint warnings #2227

Merged
merged 1 commit into from Oct 23, 2018
Merged

[docs] fix markdown lint warnings #2227

merged 1 commit into from Oct 23, 2018

Conversation

drnic
Copy link
Contributor

@drnic drnic commented Oct 13, 2018

I went through the markdown files/docs files fixing Markdown lint warnings. 馃憤

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2018
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2018
@mattmoor
Copy link
Member

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2018
vdemeester
vdemeester approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@evankanderson
Copy link
Member

Just for posterity, what tool did you use to perform the lint?

I've been using http://prettier.io/ with --prose-wrap=preserve, but I'd be happy to find a better solution.

evankanderson
evankanderson reviewed Oct 23, 2018
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drnic, evankanderson, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018
@knative-prow-robot knative-prow-robot merged commit 0506b90 into knative:master Oct 23, 2018
@drnic drnic deleted the lint-docs branch October 24, 2018 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@vdemeester vdemeester vdemeester approved these changes

@josephburnett josephburnett Awaiting requested review from josephburnett

@srinivashegde86 srinivashegde86 Awaiting requested review from srinivashegde86

@yanweiguo yanweiguo Awaiting requested review from yanweiguo

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drnic @mattmoor @evankanderson @knative-prow-robot @vdemeester