sync gateway label selector on config update #2663
Conversation
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lichuqiang If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
@lichuqiang: 1 warning.
In response to this:
To address #2434 (comment)
Proposed Changes
- Update clusteringress controller to update gateway label selector on config change
- Update related docs
Release Note
NONEClusteringress controller will update gateway label selector on config update automatically with this change; As for the
servers(port)fields in gateway, the fields can also change, and might not be so regular like that of selector: Users probably only want to expose some of the service ports in the gateway. So users will need to update the fields manually as needed.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
lichuqiang
changed the title
|
The following is the coverage report on pkg/.
|
|
@lichuqiang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @tcnghia |
|
@lichuqiang I've changed the Gateway configuration to allow exposing ClusterIngress to two or more Gateways, so this change may need a rebase? Thanks |
To address #2434 (comment)
Proposed Changes
Release Note
Clusteringress controller will update gateway label selector on config update automatically with this change; As for the
servers(port)fields in gateway, the fields can also change, and might not be so regular like that of selector: Users probably only want to expose some of the service ports in the gateway. So users will need to update the fields manually as needed.