Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra f-calls wherein no formatting is performed #3496

Merged

Conversation

vagababov
Copy link
Contributor

/lint

Proposed Changes

  • there were some eventf calls where no formatting was present, so remove f.
  • also log statements terminated with \n, which is redundant.

/assign @mattmoor

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

/lint

Proposed Changes

  • there were some eventf calls where no formatting was present, so remove f.
  • also log statements terminated with \n, which is redundant.

/assign @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Mar 22, 2019
@vagababov
Copy link
Contributor Author

/cc @mattmoor

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/autoscaling/hpa/hpa.go 84.4% 83.8% -0.7
pkg/reconciler/v1alpha1/autoscaling/kpa/kpa.go 86.8% 87.1% 0.3
pkg/reconciler/v1alpha1/clusteringress/clusteringress.go 78.6% 80.6% 2.0
pkg/reconciler/v1alpha1/configuration/configuration.go 91.5% 91.6% 0.1
pkg/reconciler/v1alpha1/revision/revision.go 90.4% 90.5% 0.1
pkg/reconciler/v1alpha1/route/route.go 92.5% 92.5% -0.0
pkg/reconciler/v1alpha1/service/service.go 92.3% 92.4% 0.1

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2019
@vagababov
Copy link
Contributor Author

/test pull-knative-serving-unit-tests

1 similar comment
@vagababov
Copy link
Contributor Author

/test pull-knative-serving-unit-tests

@knative-prow-robot knative-prow-robot merged commit 6663753 into knative:master Mar 24, 2019
@vagababov vagababov deleted the remove-extra-formatting branch April 3, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants