Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow subPath within volumeMounts. #3926

Merged
merged 1 commit into from Apr 27, 2019
Merged

Allow subPath within volumeMounts. #3926

merged 1 commit into from Apr 27, 2019

Conversation

mattmoor
Copy link
Member

Fixes: #3825

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 27, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Apr 27, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/fieldmask.go Do not exist 99.5%
pkg/apis/serving/k8s_validation.go Do not exist 98.6%

vagababov
vagababov reviewed Apr 27, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2019
@knative-prow-robot knative-prow-robot merged commit c7d563f into knative:master Apr 27, 2019
@mattmoor mattmoor deleted the volume-mount-subpath branch April 28, 2019 13:30
This was referenced Feb 3, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@grantr grantr Awaiting requested review from grantr

@jessiezcc jessiezcc Awaiting requested review from jessiezcc

Assignees

@vagababov vagababov

@dgerd dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for volumeMounts subPath
6 participants
@mattmoor @knative-prow-robot @knative-metrics-robot @vagababov @googlebot @dgerd