Make the hostname assigned to tags configurable by Operators. #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This adds a `tagTemplate` to the `config-network` ConfigMap so that (similar to
`domainTemplate`) Operators may configure how hostnames are assigned to tags.
This change just makes it configurable, a subsequent change will change the default
value to `{{.Tag}}-{{.Name}}` to reduce the likelihood of naming collisions with
BYO-revision-names
Progress towards: knative#4206
mattmoor
force-pushed
the
configurable-tag-hostnames
branch
from
04ad2d8
to
592e69f
Compare
|
The following is the coverage report on pkg/.
|
|
/lgtm Looks good! Thanks for doing some tidy-ing up as well in the tests. |
vagababov
reviewed
Jun 7, 2019
| func checkTagTemplate(t *template.Template) error { | ||
| // To a test run of applying the template, and see if we | ||
| // produce a result without error. | ||
| data := TagTemplateValues{ |
There was a problem hiding this comment.
this can probably live outside the function not to construct it each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
tagTemplateto theconfig-networkConfigMap so that (similar todomainTemplate) Operators may configure how hostnames are assigned to tags.This change just makes it configurable, a subsequent change will change the default
value to
{{.Tag}}-{{.Name}}to reduce the likelihood of naming collisions withBYO-revision-names
Progress towards: #4206