Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start autoscaler in panic mode. #4795

Merged
merged 6 commits into from
Jul 19, 2019

Commits on Jul 18, 2019

  1. Start autoscaler in panic mode.

    When autoscaler restarts it has no memory of the previous stats and immediately scales the deployment down. Under my load test conditions,
    Autoscaler goes from 7 to 1 then to 2, only then to 6 pods, before finally reaching 7 after a few cycles.
    This is obviously not a desired property, so this change fixes that behavior, by
    starting Autoscaler in panic mode with panic pod count equal to the current pod count
    if we have more than 1 serving pods right now.
    
    Obviously if the deployment is scaled to 0, there's no reason to change logic
    and if it is 1, then we won't scale below 1 anyway for the next stable window, so no need to panic either.
    
    /assign @mattmoor @markusthoemmes
    
    This is the GA scope of knative#2930
    vagababov committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    982142a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ddbe12 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae417f7 View commit details
    Browse the repository at this point in the history
  4. unit tests

    vagababov committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    fb3522f View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. updates to the imports

    vagababov committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    8aa5206 View commit details
    Browse the repository at this point in the history
  2. merge

    vagababov committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    e934cee View commit details
    Browse the repository at this point in the history