Simplify development instructions #6426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/M
knative-prow-robot
added
size/L
mattmoor
reviewed
Jan 4, 2020
DEVELOPMENT.md
Outdated
| @@ -47,6 +47,9 @@ You must install these tools: | |||
| mentioned in the sections below. | |||
| - [Google Container Registry quickstart](https://cloud.google.com/container-registry/docs/pushing-and-pulling) | |||
| - [Docker Hub quickstart](https://docs.docker.com/docker-hub/) | |||
| - If developing locally with Docker or Minikube, you can set | |||
| `KO_DOCKER_REPO=ko.local` (preferred) or use the `-L` flag to `ko` to build | |||
| and push locally (in this case, authentication is not needed).] | |||
There was a problem hiding this comment.
Suggested change
| and push locally (in this case, authentication is not needed).] | |
| and push locally (in this case, authentication is not needed). |
mattmoor
reviewed
Jan 4, 2020
knative-prow-robot
added
the
do-not-merge/hold
|
@evankanderson want to fix the trailing |
|
Updated, thanks for the ping @markusthoemmes |
knative-prow-robot
added
size/M
markusthoemmes
approved these changes
Jan 30, 2020
knative-prow-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
cluster-adminon GKE prior to k8s 1.13.-Lflagconfig-network.yamlhacks that are no longer needed post Istio-1.1.Release Note