Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup metric test #9153

Merged
merged 1 commit into from Aug 22, 2020
Merged

Cleanup metric test #9153

merged 1 commit into from Aug 22, 2020

Conversation

vagababov
Copy link
Contributor

While looking at #8868 flake, made some changes to the test itself.
I am not yet sure where does the flake come from, since it seems
the controller shutdown just lasts forever and the test times out.

/assign @yanweiguo mattmoor

@vagababov
Cleanup metric test
77b4ba5 
While looking at knative#8868 flake, made some changes to the test itself.
I am not yet sure where does the flake come from, since it seems
the controller shutdown just lasts forever and the test times out.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 21, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers labels Aug 21, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
@vagababov
Copy link
Contributor Author

BTW, when ran with race one this will fail when count=X, X> 1.
See: golang/go#40908

@vagababov vagababov mentioned this pull request Aug 21, 2020
Closed
yanweiguo
yanweiguo reviewed Aug 22, 2020
View reviewed changes
Copy link
Contributor

@yanweiguo yanweiguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests 2020-08-22 00:28:40.879 +0000 UTC 1/3
pull-knative-serving-upgrade-tests 2020-08-22 01:40:40.931 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-upgrade-tests

@knative-prow-robot knative-prow-robot merged commit cf68181 into knative:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanweiguo yanweiguo yanweiguo left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

@whaught whaught Awaiting requested review from whaught

Assignees

@mattmoor mattmoor

@yanweiguo yanweiguo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vagababov @knative-prow-robot @knative-test-reporter-robot @yanweiguo @mattmoor @googlebot