Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move responsive gc to enabled by default #9710

Merged
merged 5 commits into from Oct 13, 2020
Merged

Move responsive gc to enabled by default #9710

merged 5 commits into from Oct 13, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Oct 7, 2020 •
edited

Fixes #8208

Proposed Changes

  • Move ResponsiveRevisionGC to "enabled" by default
    • This baked as 'allowed' for .18 which continues to run the old GC along with the new. This allowed for it to be easily disabled without losing data about last-refresh.
  • The LastPinned annotation will no longer be updated on resync
    • In a future release we will remove the flag altogether along with this deprecated annotation.

Release Note

ResponsiveRevisionGC is enabled by default

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Oct 7, 2020
@whaught
Copy link
Contributor Author

whaught commented Oct 7, 2020

/assign @dprotaso @mattmoor

@whaught whaught changed the title Move responsive gc to enabled by default [WIP] Move responsive gc to enabled by default Oct 7, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020 •
edited

Codecov Report

Merging #9710 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9710      +/-   ##
==========================================
+ Coverage   87.94%   88.00%   +0.05%     
==========================================
  Files         177      177              
  Lines        8447     8447              
==========================================
+ Hits         7429     7434       +5     
+ Misses        773      771       -2     
+ Partials      245      242       -3
Impacted Files Coverage Δ
pkg/apis/config/features.go 93.75% <100.00%> (ø)
pkg/reconciler/service/resources/configuration.go 100.00% <100.00%> (ø)
pkg/reconciler/route/reconcile_resources.go 74.41% <0.00%> (-0.78%) ⬇️
pkg/autoscaler/statforwarder/forwarder.go 84.11% <0.00%> (+1.17%) ⬆️
pkg/reconciler/autoscaling/kpa/scaler.go 90.00% <0.00%> (+1.42%) ⬆️
pkg/reconciler/configuration/configuration.go 89.16% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2708c32...f593042. Read the comment docs.

@whaught whaught changed the title [WIP] Move responsive gc to enabled by default Move responsive gc to enabled by default Oct 7, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Oct 7, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-istio-stable-no-mesh 2020-10-07 04:28:13.504 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-istio-stable-no-mesh

markusthoemmes
markusthoemmes reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
vagababov
vagababov reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @dprotaso mattmoor

@dprotaso
Copy link
Member

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@knative-prow-robot knative-prow-robot merged commit 0852b9f into knative:master Oct 13, 2020
navidshaikh added a commit to navidshaikh/client that referenced this pull request Oct 15, 2020
@navidshaikh
fix(e2e): Remove "serving.knative.dev/route" revision label
6b02368 
  Dont expect mentioned key on the revision labels in service
  expect tests now. The test is skipped for serving v0.18 release
  and configured to only against current serving master.
  see #knative/serving#9710
@navidshaikh navidshaikh mentioned this pull request Oct 15, 2020
Merged
navidshaikh added a commit to navidshaikh/client that referenced this pull request Oct 15, 2020
@navidshaikh
fix(e2e): Remove "serving.knative.dev/route" revision label
6e80254 
  Dont expect mentioned key on the revision labels in service
  expect tests now. The test is skipped for serving v0.18 release
  and configured to only against current serving master.
  see #knative/serving#9710
knative-prow-robot pushed a commit to knative/client that referenced this pull request Oct 15, 2020
@navidshaikh
fix(e2e): Remove "serving.knative.dev/route" revision label (#1067)
ce1f43c 
Dont expect mentioned key on the revision labels in service
  expect tests now. The test is skipped for serving v0.18 release
  and configured to only against current serving master.
  see #knative/serving#9710
@whaught whaught deleted the gc-enabled-default branch January 13, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes left review comments

@vagababov vagababov vagababov approved these changes

@grantr grantr Awaiting requested review from grantr

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

Assignees

@dprotaso dprotaso

@vagababov vagababov

@markusthoemmes markusthoemmes

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More aggressive Revision GC settings
7 participants
@whaught @knative-test-reporter-robot @dprotaso @knative-prow-robot @vagababov @markusthoemmes @mattmoor