Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EasyCLA and Tide (from Slack) #3708

Closed
krsna-m opened this issue Feb 7, 2023 · 1 comment
Closed

EasyCLA and Tide (from Slack) #3708

krsna-m opened this issue Feb 7, 2023 · 1 comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@krsna-m
Copy link
Contributor

krsna-m commented Feb 7, 2023

From @aliok :

There's an issue with EasyCLA and Prow.
A PR can be put in the merge queue w/o the CLA. But, it won't be merged by Prow.
And, since it is a FIFO queue, that PR will block every other valid PR for a repository.
It was happening before (https://cloud-native.slack.com/archives/C04LY4M2G49/p1675237966468319) and I saw it happened again now.
https://github.com/knative/docs/pull/5381 is approved and has lgtm, but CLA authorization is missing.
If you check Tide (https://prow.knative.dev/tide), you can see it is in the merge queue and it waits there forever.
https://github.com/knative/docs/pull/5402 for example is all good (approved, CLA authorized, lgtm'ed) and is also in the merge queue. It just sits there forever.
For workaround we can add a /hold to 5381 and 5402 will be unblocked.

#5381 Fixes a typo in docs
#5402 Update the advanced istio installation docs

@github-actions
Copy link

github-actions bot commented May 9, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2023
@github-actions github-actions bot closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant