Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a typo in docs #5381

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fixes a typo in docs #5381

merged 1 commit into from
Feb 3, 2023

Conversation

MichalPitr
Copy link
Contributor

This PR fixes a simple typo.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 14, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MichalPitr / name: michal pitr (065e796)

@knative-prow
Copy link

knative-prow bot commented Jan 14, 2023

Welcome @MichalPitr! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2023
@netlify
Copy link

netlify bot commented Jan 14, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 065e796
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/63c316c898bc0d00084d8852
😎 Deploy Preview https://deploy-preview-5381--knative.netlify.app/docs/serving/observability/metrics/serving-metrics
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@psschwei
Copy link
Contributor

Thanks for the PR @MichalPitr ! Once you sign the EasyCLA, we can merge this.

evankanderson
evankanderson reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, MichalPitr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@aliok
Copy link
Member

aliok commented Feb 1, 2023

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023
@aliok
Copy link
Member

aliok commented Feb 1, 2023 •
edited
Loading

Added hold so that 5393 could be merged. Please unhold when CLA issue is fixed.

See https://cloud-native.slack.com/archives/C04LY4M2G49/p1675237966468319 for more information about the Prow issue

@evankanderson
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@ReToCode
Copy link
Member

ReToCode commented Feb 3, 2023 •
edited
Loading

/hold

for EasyCLA to be signed. More info above: #5381 (comment)

@aliok
Copy link
Member

aliok commented Feb 3, 2023

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@MichalPitr
Copy link
Contributor Author

/easycla

@MichalPitr
Copy link
Contributor Author

@psschwei when I click on the "authorize" link, I get the following error message:{"errors": {"Invalid OAuth2 state": "NnjotKHWVbngrv5PQft3gCALx65RfE"}}

Am I missing some steps?

@psschwei
Copy link
Contributor

psschwei commented Feb 3, 2023

Have you authorized the Linux Foundation: EasyCLA oauth app? I'm pretty sure that's what's handling the oauth (but will tag @kvmware @upodroid to confirm)

@MichalPitr
Copy link
Contributor Author

@psschwei Should be good now! I was trying to sign it from a mobile device and it seemingly doesn't work there. Works fine on a desktop.

@psschwei
Copy link
Contributor

psschwei commented Feb 3, 2023

Awesome! Thanks for the PR (and for working through the CLA issues 😄 ) !

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@knative-prow knative-prow bot merged commit 7afbdf4 into knative:main Feb 3, 2023
@krsna-m krsna-m mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichalPitr @psschwei @aliok @evankanderson @ReToCode